Fix/broken table generation #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boriel
commented
Dec 14, 2024
| "union-attr", | ||
| "var-annotated", | ||
| ] | ||
| exclude = [ |
Collaborator
Author
There was a problem hiding this comment.
@bartsanchez The entire src/ply/*.py should be excluded.
Fixing linting in these 3rd party files might introduce bugs and the lints are lost every time the library is updated (fortunately is a very stable one, so no need to update it very often).
boriel
commented
Dec 14, 2024
Collaborator
Author
There was a problem hiding this comment.
These are binary (pickled / Python serialized) classes. The compiler takes like 10 seconds or more to generate these tables upon start up. With this cache the start time is < 1 sec.
boriel
commented
Dec 14, 2024
|
|
||
| from src.ply.yacc import LRParser | ||
|
|
||
|
|
Collaborator
Author
There was a problem hiding this comment.
This test now checks that the compiler correctly builds the parsetabs, so if we decide to change PLY again in the future this will check the tables are correctly rebuild again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927